The Adblock Project Forum Index The Adblock Project
Pull up a seat ...stay a while.
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Header image conundrum

 
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main
View previous topic :: View next topic  
Author Message
twoflush



Joined: 05 Apr 2005
Posts: 3

PostPosted: Tue Apr 05, 2005    Post subject: Header image conundrum Reply with quote

Hi.

I like this plugin. However, I just found out that it blocks the header gif on one of my sites.

At first I thought it must be clashing with an entry on a giant filter list I got from a friend, but it continued to block it when I'd deleted all of the filters.

I then uninstalled the plugin, and it showed once again. Reinstall: header disappears!

With an experiment, I found that using the image as a hyperlink allowed it to show up with adblock on.

My AdBlock prefs show I'm using 0.5 Nightly * build 39. I'm also running FF 1.0.2 under Win2KSP4. Does anyone have any idea why this is happening? Is this a bug with AdBlock, or could there be some residue from the filter list I was using when I first installed it?
Back to top
View user's profile Send private message
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Tue Apr 05, 2005    Post subject: Reply with quote

Interesting. This bug appears in 0.6 too, even when Adblock is "disabled" (e.g. from the Prefs window, rather than the EM).

It certainly sounds like an Adblock bug.
No time tonight, but I'll look into this ASAP.
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
twoflush



Joined: 05 Apr 2005
Posts: 3

PostPosted: Sun Apr 10, 2005    Post subject: Reply with quote

Cool, thanks.
Back to top
View user's profile Send private message
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Wed Apr 13, 2005    Post subject: Reply with quote

Well, I narrowed it down to one line of code. We're setting an attribute on the node, and for some reason that's causing it to disappear. To be clear: setting an attribute on a node should NOT be making it vanish.

We should probably punt this one off to the Mozilla folk as a Gecko/DOM/layout bug.
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
Guest






PostPosted: Thu Apr 21, 2005    Post subject: Reply with quote

Thanks for looking into it.
Back to top
twoflush



Joined: 05 Apr 2005
Posts: 3

PostPosted: Fri Apr 22, 2005    Post subject: Reply with quote

It seems to be fixed with FF 1.0.3 Smile
Back to top
View user's profile Send private message
kstahl
Support


Joined: 02 Jan 2004
Posts: 1202
Location: Stockholm, Sweden

PostPosted: Fri Apr 22, 2005    Post subject: Reply with quote

Interesting. So it was probably an obscure rendering bug in Firefox that Adblock just happened to expose.
_________________
Adblock 0.5.3.042
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.Cool Gecko/20051111 Firefox/1.5
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group