The Adblock Project Forum Index The Adblock Project
Pull up a seat ...stay a while.
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Adblock causes this site to not render properly.

 
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main
View previous topic :: View next topic  
Author Message
CPeanutG
Guest





PostPosted: Mon Jan 17, 2005    Post subject: Adblock causes this site to not render properly. Reply with quote

I am running the latest versions of Firefox and Adblock. I have ruled out any other plugins I have installed at being at fault for this error. When Adblock is enabled in the Extensions window, and either Enabled or Disabled it Adblock's own preferences window, it causes this sites Server Status, which is the ServerSpy Mini Monitor script, to not render.

http://www.snarkcafe.net/ look for it on the right side.

ServerSpy web site http://www.serverspy.net/
Back to top
CPeanutG
Guest





PostPosted: Mon Jan 17, 2005    Post subject: Reply with quote

Heres the source for the MiniMonitor.

Code:
<!-- ServerSpy Mini Monitor Div -->
<div id="ssmini73589" class="ssminiloading">Loading Mini Monitor..<br>Please Wait</div>
<!-- server spy mini end -->
<!-- serverspy.net mini monitor logic [ for monitor 5311 ] start -->
<script language="javascript">ssMiniId = 'ssmini73589';</script>
<script language="javascript" src="http://share1.serverspy.net/cgi-bin/monitor.js?mid=73589"></script>
<!-- serverspy.net mini monitor logic [ for monitor 5311 ] end -->
<!-- Server Spy Mini End -->
Back to top
Guest
Guest





PostPosted: Mon Jan 24, 2005    Post subject: This site doesn't display properly either. Reply with quote

http://www.speedtv.com/

Mac OS X v10.3.7

Firefox v1.0
Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Back to top
Johnny2
Guest





PostPosted: Wed Jan 26, 2005    Post subject: Re: Adblock causes this site to not render properly. Reply with quote

CPeanutG wrote:
I am running the latest versions of Firefox and Adblock. I have ruled out any other plugins I have installed at being at fault for this error. When Adblock is enabled in the Extensions window, and either Enabled or Disabled it Adblock's own preferences window, it causes this sites Server Status, which is the ServerSpy Mini Monitor script, to not render.

http://www.snarkcafe.net/ look for it on the right side.

ServerSpy web site http://www.serverspy.net/


I loaded up the page, and everything works like a charm.
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Wed Jan 26, 2005    Post subject: Reply with quote

CPeanutG: When loading your page with Adblock enabled, the JavaScript Console prints out the following error messages:

Code:
Warning: reference to undefined property plugin.SetWindow
Source File: javascript: function jsScriptObject(obj) { this.wrappedJSObject = obj; } jsScriptObject.prototype = { evaluate : function(expression) { return new jsScriptObject(eval(expression)); } }; var plugin = document.embeds['smon73589']; plugin.SetWindow(new jsScriptObject(window),2039527021);
Line: 1


Code:
Error: plugin.SetWindow is not a function
Source File: javascript: function jsScriptObject(obj) { this.wrappedJSObject = obj; } jsScriptObject.prototype = { evaluate : function(expression) { return new jsScriptObject(eval(expression)); } }; var plugin = document.embeds['smon73589']; plugin.SetWindow(new jsScriptObject(window),2039527021);
Line: 1


When I navigate to another URL, the Console says this:

Code:
Attempt to load a javascript: URL from one host
in a window displaying content from another host
was blocked by the security manager.


That said, the tables are loaded properly when Adblock is disabled. Strange, but I'm not entirely sure what Adblock is doing to cause this, or if it should even be considered Adblock's fault. Some of the JavaScript there is pretty atrocious: it writes VBScript even when it knows the browser is Firefox, it tests for variables before setting/defining them... as far as I can tell, the actual code that writes the table is embedded in the "rendering" swf? I can't really see what's going wrong, so I have no idea where to begin looking for what to fix, if anything.

The code includes this comment:
Code:
// Fix for Flash security issue where javascript can't talk to flash
so it sounds like they're aware of this issue in general, but aren't detecting it correctly when Adblock is installed.
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
Guest






PostPosted: Thu Mar 24, 2005    Post subject: Reply with quote

URL where this happens:
http://www.newscientist.com/article.ns?id=dn7195

Image that shows how the page looks like when it's incorrectly rendered. Just to show you that I'm not making things up. (texts are over the links on the right)
http://personal.inet.fi/koti/aggro/text_over.png

And here is what it should look a like:
http://personal.inet.fi/koti/aggro/not_over.png

Steps to repeat the behaviour:
0. You should have Adblock installed and enabled
1. Close all Firefox windows and open a brand new one.
2. Select Tools -> Options -> Privacy -> Clear cache
3. Go to URL: http://www.newscientist.com/article.ns?id=dn7195
* Page should render incorrectly.

5. Press refresh
* Page should render correctly

6. Close your browser window and go again to the given url.
* Page should render correctly.

7. Disable adblock
8. Restart browser
9. Clear cache
10. Go to given URL
* Page should render correctly.

So only if you don't have the page in your cache and you have adblock enabled, the page will be rendered incorrectly. I have not yet failed once repeating this behaviour. I will now check does it matter what kind of blocks I'm using...

System information:
I have Firefox 1.0.2 on Windows 2000 + SP4
Adblock version: 0.5.2.039
Back to top
Guest






PostPosted: Thu Mar 24, 2005    Post subject: Reply with quote

I have done more research. If you test the above, you should have only one filter (propably it works also if you many as it worked with me), but this is the critical filter:

http://adserver.*

With adblock having only this filter, the bug can be reproduced. With empty or with random filters the bug won't appear, so this propably affects the page rendering process somehow.

Please see if you can fix this or if you need more info about this bug. This is the best I could do to tell you how to reproduce this bug.
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Fri Mar 25, 2005    Post subject: Reply with quote

Guest: With our latest code (unreleased) this appears fixed.

Excellent work with instructions/testcase, by the way. If only more users could provide such detailed instructions for bug reports... =/
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
Guest






PostPosted: Fri Mar 25, 2005    Post subject: Reply with quote

Got any idea, why the fixed version is not available via Firefox tools -> extensions -> update? Who desides when new versions are put there and is there anything I can do to speed it up?

I know I could download and install the extensions directly from here, but I would prefer to use the update-tool to keep all extensions updated. If only that thing would actually give updates ;)
Back to top
kstahl
Support


Joined: 02 Jan 2004
Posts: 1202
Location: Stockholm, Sweden

PostPosted: Fri Mar 25, 2005    Post subject: Reply with quote

Adblock 0.6 has not been released yet.
_________________
Adblock 0.5.3.042
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.Cool Gecko/20051111 Firefox/1.5
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group