The Adblock Project Forum Index The Adblock Project
Pull up a seat ...stay a while.
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Patched Adblock

 
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main
View previous topic :: View next topic  
Author Message
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Sat May 22, 2004    Post subject: Patched Adblock Reply with quote

All right. I've spent the past day or so hacking around with rue's latest n37 release, and have come up with an improved version.

Issues fixed from/improvements over vanilla n37:

    *Repackaged for 0.9 EM, maintaining backwards-compatibility
    * iFrame collapsation no longer broken (no white pages [ versiontracker.com ] , no crashes in mozilla on slashdot.org with the filter /[\/.]ads?[\/.]/)
    * Fixed dragging to allow statusbar element to be dragged to the edges of the statusbar.
    * Added dynamic contextmenu to statusbar element that allows for enabling/disabling adblock straight from the mouse.</li>
    * Added preliminary About and Getting Started dialogs/help pages.</li>
    * Added (functioning) Load Default Filters from Web menuitem.</li>
    * Reworked Adblock-able Items dialog to have an Add button and a Close Dialog button, rather than OK and Cancel. Allows more than one filter addition without reopening the dialog.</li>
    * My server also serves .XPI files as application/x-xpinstall, whereas rue's .Mac account seems to be serving them as application/octetstream ( ok, that one's a stretch Smile )

There are probably some other changes in there, but it's 3 AM and my brain is shutting down. I'll check back here tomorrow afternoon when I wake up. Post any issues you encounter and I'll look into a fix.

There are one or two issues which I'm already aware of (very minor bugs), but I can't really recall them at the moment. Obj-tabs and Overlay Flash are both nonfunctional, unchanged from vanilla n37.


Anyways, here's the new file:
http://www.eschew.org/misc/firefox/adblock.n37-repackaged01.xpi


Last edited by wonkothesane on Mon May 31, 2004; edited 21 times in total
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
mark
Guest





PostPosted: Sat May 22, 2004    Post subject: Reply with quote

Thanks!!

Gonna test it now!
Back to top
mark
Guest





PostPosted: Sat May 22, 2004    Post subject: Reply with quote

Doesn't work Sad.
Installed into profile dir.

Using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040521 Firefox/0.8.
Back to top
Guest






PostPosted: Sat May 22, 2004    Post subject: Reply with quote

mark wrote:
Doesn't work Sad.
Installed into profile dir.

Using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040521 Firefox/0.8.


Note the 0.8. As far as I know, that indicates a branch build, rather than a trunk build, and as I mentioned, the branch builds work with the old version.

Or am I missing something?
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Sat May 22, 2004    Post subject: Addendum Reply with quote

You'll almost certainly need to use a fresh profile for this to work right... sorry for not mentioning that earlier.

If it persists in not working even with a fresh install/profile, let me know what your UA string is and I'll download that build and test it.

Also verified with

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a) Gecko/20040514 Firefox/0.8.0+

It shouldn't matter where you install it.

{edit} I'm in the process of getting the server to serve XPI files as mimetype application/x-xpinstall, but for now, you'll want to save the XPI file to your hard drive and install it from there. {/edit}
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
koniu
Guest





PostPosted: Sun May 23, 2004    Post subject: Reply with quote

neither this version nor the one from adblock.mozdev.org version works with either of:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a) Gecko/20040515 Firefox/0.8.0+
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040521 Firefox/0.8.0+
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040522 Firefox/0.8.0+

0515 was my own cvs build with gtk2+xft
052x were gtk2+xft nightlies from ftp.mozilla.org

no difference when installed in the global dir.
each test was done with a clean install - untouched rootdir, null profile.
Back to top
mark
Guest





PostPosted: Sun May 23, 2004    Post subject: Reply with quote

Well I'm using a nightly from 2 days ago - shouldn't be a problem?

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040521 Firefox/0.8
Back to top
Sven
Guest





PostPosted: Sun May 23, 2004    Post subject: Reply with quote

I tested the patched Adblock with Seamonkey 1.8a 20040523. The new version does not break Mozilla anymore but it does not filter any content. Also the list when clicking on the Adblock "button" is empty.
Back to top
Konul
Guest





PostPosted: Sun May 23, 2004    Post subject: Reply with quote

It is like Sven descriped it: U can still brwose with the Plugin, but it is doesnt filter at all. the filter list is always emty, and "AdBlock Image" when u klick on images has no function.

maybe some more api calls need to be fixed.
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Sun May 23, 2004    Post subject: Reply with quote

Yes, I noticed that it didn't actually work a bit after releasing the second patched version.

I'll work on it for a while and see if I can hunt down the changed APIs, though I probably won't get done much today as I have a paper due tomorrow for school.

I can get filterlist entries to persist, but almost everything else seems borked.

My apologies for being premature with my releases of the patched versions. Embarassed
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Tue May 25, 2004    Post subject: good news for people who love good news :) Reply with quote

ping! check out the first message (just click here:)

http://aasted.org/adblock/viewtopic.php?p=2507#2507
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
joe
Guest





PostPosted: Tue May 25, 2004    Post subject: Mac Reply with quote

The updated adblock does not work with the latest version of firefox for the mac. Just FYI.
Back to top
koniu
Guest





PostPosted: Tue May 25, 2004    Post subject: Reply with quote

first of all, wonkothesane, let thy name be praised for doing this!
yes, this means that i confirm that it works now.

the bug you've described is there but it also seems to produce a crash with my firefox (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a) Gecko/20040515 Firefox/0.8.0+)

also the list of all blockable elements is always empty, with any site. only when i block something through right-click it gets a single entry of the element that was blocked. anybody else suffering from that? (if not - what nightly u use?)

otherwise, everything seems just perfect.
Back to top
koniu
Guest





PostPosted: Tue May 25, 2004    Post subject: Reply with quote

ah, one more thing - as you said, the crash doesn't occur when i switch from "remove ads" to "hide ads", but then the hidden elements don't get collapsed which disables one of the finest features of adblock Neutral
Back to top
koniu
Guest





PostPosted: Tue May 25, 2004    Post subject: Reply with quote

ok. the blocked ads (hidden) do sometimes get collapsed. but not always. i couldn't figure out the circumstances.

next - flash elements don't have this nice "adblock" button. it was a nice feature, now i have to use this ugly "overlay flash" way

finally - if you do "adblock image" with one refered through relative url, you get only this relative part of url in "add adblock filter" dialogue which is not really the way it should be.
Back to top
Tony



Joined: 24 May 2004
Posts: 1

PostPosted: Tue May 25, 2004    Post subject: Reply with quote

koniu wrote:
also the list of all blockable elements is always empty, with any site. only when i block something through right-click it gets a single entry of the element that was blocked. anybody else suffering from that? (if not - what nightly u use?)

Same for me with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040524 Firefox/0.8.0+
Back to top
View user's profile Send private message
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Tue May 25, 2004    Post subject: thanks! Reply with quote

Thank you for the good bugtesting, koniu.

I've gotten almost everything working well, certainly all the major components; same URL @ eschew.org but new XPI

I'll work on getting the minor things fixed next.
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
Guest






PostPosted: Wed May 26, 2004    Post subject: Reply with quote

I get a "Not a valid install package" when I attempt to install this.
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Wed May 26, 2004    Post subject: fixed Reply with quote

Anonymous wrote:
I get a "Not a valid install package" when I attempt to install this.


Fixed. Clear your cache if the issue persists.
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
koniu
Guest





PostPosted: Wed May 26, 2004    Post subject: Reply with quote

a suggestion and some findings with "fourth update"

a suggestion is: wonkonthesane, it would be neat if you upgraded a version string with each release. add -wots<incremental-number> or sth like that. this won't hurt and might prevent some mess in the future.

now the findings.
first of all, i can't get the debug version to install. my firefox (Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a) Gecko/20040515 Firefox/0.8.0+) bails out as soon as i click OK on the "extension installed, please restart yr browser" dialogue. on the system console i get:

Code:

(Gecko:19742): GLib-GObject-WARNING **: invalid uninstantiatable type `<invalid>' in cast to `GtkWidget'

(Gecko:19742): GLib-GObject-WARNING **: invalid uninstantiatable type `<invalid>' in cast to `GObject'

(Gecko:19742): GLib-GObject-CRITICAL **: file gobject.c: line 1642 (g_object_get_data): assertion `G_IS_OBJECT (object)' failed


second, i confirm - relative urls and blockable elements do work ok now.

third - i confirm that "adblock" tab with flash elements appears but... the flash elements themself don't show up (no, they're not blocked Smile).
i've noticed that in the js console i get "removal of obj-tab frame failed" for each site with flash banner or sth like that.

anyway, thanks for your great job again! (btw, i'm starting to believe that rue's post on mozillazine forums was a fake indeed)
Back to top
koniu
Guest





PostPosted: Wed May 26, 2004    Post subject: Reply with quote

oh and it seems that the remove+collapse crash (like with /.) doesn't occur anymore.

this would mean that the only issue i see is this broken flash ("adblock" tab shows up, but the flash element itself not) thing.

...which implies that you're my hero! Rolling Eyes
Back to top
kmike
Guest





PostPosted: Wed May 26, 2004    Post subject: Reply with quote

Non-debug fourth update indeed blocks content in Linux SeaMonkey 20040526 build, but I can't add new filter via "list all blockable elements in thi s page" command.
I see this error in javascript console:
Quote:

Error: selection has no properties
Source File: chrome://adblock/content/filterall.js
Line: 172
Back to top
kmike
Guest





PostPosted: Wed May 26, 2004    Post subject: another bug Reply with quote

Another interesting but so far harmless(?) bug.
Steps to reproduce:

1. Add this to filter list:
/\W(cy|r)?c(ou)?nt(er|ed)?\W/

2. Righ click this URL: http://ln.hixie.ch/?start=1085056751&count=1
and select "open link in new tab"
observe blank page in new tab (this wasn't the case before new ContentPolicy - the blocked page itself loaded fine before, but I guess new behaviour makes sense)

3. open javascript console, observe this error:
Quote:

Error: uncaught exception: [Exception... "Component returned failure code: 0x805e000a [nsIWebNavigation.loadURI]" nsresult: "0x805e000a (<unknown>)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 144" data: no]


I first saw this after doing "open link in new tab" on that particular link from mozillazine's front page.
Back to top
Guest






PostPosted: Wed May 26, 2004    Post subject: Reply with quote

kmike wrote:
Non-debug fourth update indeed blocks content in Linux SeaMonkey 20040526 build, but I can't add new filter via "list all blockable elements in thi s page" command.


I installed adblock-debug.xpi, now I get this in javascript console when using "list all blockable elements" command:
Quote:

Error: tree.treeBoxObject.selection has no properties
Source File: chrome://adblock/content/filterall.js
Line: 158

seems like this is what causing onSelectionChange to fail with "selection has no properties" error.

Also, the actual object list in "All blockable items" is always showing only blocked items...
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Wed May 26, 2004    Post subject: Reply with quote

Anonymous wrote:
kmike wrote:
Non-debug fourth update indeed blocks content in Linux SeaMonkey 20040526 build, but I can't add new filter via "list all blockable elements in thi s page" command.


I installed adblock-debug.xpi, now I get this in javascript console when using "list all blockable elements" command:
Quote:

Error: tree.treeBoxObject.selection has no properties
Source File: chrome://adblock/content/filterall.js
Line: 158

seems like this is what causing onSelectionChange to fail with "selection has no properties" error.

Also, the actual object list in "All blockable items" is always showing only blocked items...


Yes, I probably shouldn't have uploaded the that adblock-debug.xpi, as it was an older version with debug statements -- and as you found, some of the minor bugs -- in all the files to track the flow of execution across files. For everyone who installed the adblock-debug.xpi version, please uninstall and try the "conventional" adblock-patched.xpi

To avoid this in the future, I'll start versioning future updates (hopefully not too many, as I want to start helping out with getting n37 working). And I don't think rue's post was a fake, as he PMed me and talked about adblock in enough detail to make me believe that if his account has been hacked, it's by another adblock developer Smile
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Wed May 26, 2004    Post subject: Re: another bug Reply with quote

kmike wrote:
Another interesting but so far harmless(?) bug.
Steps to reproduce:

1. Add this to filter list:
/\W(cy|r)?c(ou)?nt(er|ed)?\W/

2. Righ click this URL: http://ln.hixie.ch/?start=1085056751&count=1
and select "open link in new tab"
observe blank page in new tab (this wasn't the case before new ContentPolicy - the blocked page itself loaded fine before, but I guess new behaviour makes sense)

3. open javascript console, observe this error:
Quote:

Error: uncaught exception: [Exception... "Component returned failure code: 0x805e000a [nsIWebNavigation.loadURI]" nsresult: "0x805e000a (<unknown>)" location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 144" data: no]


I first saw this after doing "open link in new tab" on that particular link from mozillazine's front page.


I'm pretty sure I know exactly how to fix this, but I won't be able to upload a new version until I get home this afternoon.

(I think) Essentially, I forgot to make the code stop executing if it's a document and pageblock isn't on.
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
anonymous2
Guest





PostPosted: Thu May 27, 2004    Post subject: latest patch Reply with quote

thanks wonkothesane for all the work, what's the url of the latest patch/update for adblock?
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Thu May 27, 2004    Post subject: Re: latest patch Reply with quote

anonymous2 wrote:
thanks wonkothesane for all the work, what's the url of the latest patch/update for adblock?


Well, for my patched copy, you can find it at the top of this thread or you can find it over at the mozillazine.org forums under the Extensions subforum. I've decided change the specific URL whenever I update the XPI so that it'll be easier to identify what people have installed, though it'll only be the URL; in the browser, the identifying text will not change.

For the "official" version (which will, at some point in the hopefully near future , work with both APIs like mine), you'll probably find it posted on adblock.mozdev.org
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
kmike



Joined: 27 May 2004
Posts: 6

PostPosted: Thu May 27, 2004    Post subject: Reply with quote

Yes, its a very good idea to add versioning to patched adblock.

So, I installed adblock-patched05.xpi, but I still can't add new items via ctrl-shift-A command. Get the same Javascript error:
Quote:

Error: selection has no properties
Source File: chrome://adblock/content/filterall.js
Line: 172
Back to top
View user's profile Send private message
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Thu May 27, 2004    Post subject: Reply with quote

kmike wrote:
Yes, its a very good idea to add versioning to patched adblock.

So, I installed adblock-patched05.xpi, but I still can't add new items via ctrl-shift-A command. Get the same Javascript error:
Quote:

Error: selection has no properties
Source File: chrome://adblock/content/filterall.js
Line: 172


What is your UA string from your browser?

Also, is the loadURI bug fixed on your install with adblock-patched05.xpi ?

Thank you for the bugtesting, by the way Smile
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
lethal_falcon



Joined: 27 May 2004
Posts: 2

PostPosted: Thu May 27, 2004    Post subject: Reply with quote

I've noticed this problem for quite some time now with all the builds I've tried (both firefox and adblock). You can pull up the adblock-able items window, but when you click on any of the elements, it no longer adds it to the New Filter textbox. Manually typing in the address does work for me.

I think there should be an add button in that window as well, so that you can block multiple items from the window with just a couple of clicks (instead of adding one, clicking ok, opening it back up, adding another, etc.). At least with the latest builds the patched version is working again to an extent.

Keep up the good work!
_________________
Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8a2) Gecko/20040527 Firefox/0.8.0+ (stipe)

adblock-patched06.xpi
Back to top
View user's profile Send private message
kmike



Joined: 27 May 2004
Posts: 6

PostPosted: Thu May 27, 2004    Post subject: Reply with quote

lethal_falcon:
I believe you're describing the very same bug we're discussing Smile

wonkothesane:
Yes, no more loadURI exceptions with patched05 version. Thank you for quick fix Smile
My UA is Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040526.
Back to top
View user's profile Send private message
kmike



Joined: 27 May 2004
Posts: 6

PostPosted: Fri May 28, 2004    Post subject: Reply with quote

Quote:

The problem is that I tried testing the "official" adblock xpi on some older Firefox/Mozilla builds, and this feature didn't work in the two builds I tried (both from the first week of May.) Combine that with the fact that I don't view this as a particularly critical bug, and I probably won't fix this anytime soon unless a) a few people ask for it and b) somebody gives me a UA string for a browser that this feature works in when using the official adblock xpi.

Ok, here's the build with working feature in question:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040321
The problem is that its kind of old... no nightlies of that period at ftp.mozilla.org, sorry Sad
I'll try to download some random nightlies and see if it works.

UPDATE:
Tried 2004041810 trunk nightly build, the same error as in the current trunk: "selection has no properties". I'll try the earliest trunk build available from ftp.mozilla.org (2004-04-07-09)
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Fri May 28, 2004    Post subject: Reply with quote

Everyone:
Just a quick heads-up:
.
The "patched" build is not the future of Adblock. It's a good tide-over until n37; but the reason it's failing is the cumbersome nature of its design -- essentially maintaining two copies of code for the differing APIs.
.
n37 addresses the APIs in a unified manner, minimizing overhead. Where n37 fails is the same place the unreleased n36 did. Amusingly, it's been held-up due to lack of a proper test-box -- an issue that should shortly be resolved. Btw, moz1.3.1 under macOs 9 runs n37 fine. You can scope the latest source here:
n37 test.ii . (right-click:save): Installer, and jar-file.
[ This is not linked for install. Only download if you're interested in the source. ]
Travels, graduations, and other events did beckon away for a time. But I'm on top of all pertinent threads, and development has resumed. Keep it here.
Back to top
View user's profile Send private message
koniu
Guest





PostPosted: Fri May 28, 2004    Post subject: Reply with quote

**woohoo** Pray Dancing
Back to top
koniu
Guest





PostPosted: Fri May 28, 2004    Post subject: Reply with quote

but on a [second] thought....

i've installed n37 with a fresh profile and it breaks my browser in the same manner n35 did - 'adblock' button appears in a bottom right(!) corner of the window and i can enter an url into the address bar but i can't get it to load thus the browser is unusable.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040526 Firefox/0.8.0+

getting back to wonkothesane's patch which might not be the future, but seems to be the presence Twisted Evil
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Fri May 28, 2004    Post subject: Reply with quote

koniu:
As indicated, it is known to fail ( - though for different reasons than n35). I only linked because there are curious individuals and we've always been open with progress.
.
Install the patched build if you need it. It's a good interim.
.
Note: the status-element was always intended to be Right aligned. Because I develop under 1.3.1, I didn't know it appeared wrongly under recent builds. n36 introduced drag-relocation, so when we're final you can just kick it how you like.
Back to top
View user's profile Send private message
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Fri May 28, 2004    Post subject: Reply with quote

Rue is,of course correct in his observation that this patched version is just that, a patched version that has been intended as a temporary salve until the official version worked correctly.

I think I disagree as to saying that the code is failing due to "cumbersome" design; I think it (was/is) failing because I changed pieces of code I shouldn't have, the fact that it's almost all trial-and-error for me, learning as I go, and that I have nothing in the way of comprehensive unit testing. I think I've created over fifty patched XPIs from modified source as part of that trial and error process.

The two component.js file solution may not be terribly elegant, but it does have two notable advantages, the first being that it works. That's not to say that it working is due to the design of the solution, but instead it's more directly related to the second advantage, that being that it separates the logic reqiured to support the two APIs, allowing for uninhibited adaptation to the new API while preserving the logic of the old, and eventually allowing the two to be merged into a common logic base, which is what n37 is soon going to be.

Even though there is quite a bit of duplicated code, the ZIP compression means that the patched XPI is only 10-15 KB larger than n35. And actually, rue, on the subject of duplicated code... pot kettle black? Smile True. it's not 40+ KB of duplicated code, but adblock does have quite a few copied-and-pasted code sections.

Of course, the irony of this is that, because rue doesn't actually have browsers with the new API to test on, one can postulate that I've probably delayed the release of n37 by a few days by working with the old codebase instead of the new one. Still, I feel that that influence is offset by the experience and familiarity I've gained with the code, which should hopefully mean less time for me to get n37 working and submit the changes to rue, should they be needed.


On the subject of n35 and the patched version, I think I'll probably only release maybe one more update (investigation into repackaging for 0.9 and hopefully a forced reflow after adding a filter via addfilter.xul. Due to the scrapping of install.js, replaced by install.rdf, I'm not sure off the top of my head whether two separate component.js files can actually be used; they probably can, but I'm at school right now and will have to wait to get home before I can verify or disprove my intution.)


Also, rue: is there any possibilty of packaging a default dozen or so filters with new installations of adblock, so that it can start blocking ads "right out of the box"? I think that this would help adblock appeal to a wider, non-technical audience.

Bell just rung, so I've gotta go.[/b]
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Fri May 28, 2004    Post subject: Reply with quote

wonko:
..it's almost all trial-and-error for me..
I tried not to directly state, but "cumbersome nature" was meta-implicating your capacity. I could see you were getting a feel for things by the comments / typos (.DefaultView ;P)
.
Per n37, I may have found a better solution than eval'ing different strings for the origContentPolicy calls. It seems the following syntax is permitted:
Code:
// apiConstants is an object, but .notReal is NOT defined for it.
// this allows us to pass "undefined", maintaining two
// totally different calls in one line
origContentPolicy.shouldLoad(
            contentType, contentLocation,
            requestOrigin, requestingNode,
            apiConstants.oldStyleAPI?apiConstants.notReal:mimeTypeGuess,
            apiConstants.oldStyleAPI?apiConstants.notReal:extra
      );
.
Oh, and per "out-of-the-box" filtering: we've mostly tried to stay away, since one user's false-positive is another's eye-stabbing annoyance. If we default-install the "Advanced Filters": a.) new users wouldn't learn how to manage filters, and b.) we'd have a perpetual "hey- false-positive!" thread. ...Of course, these might be acceptable trade-offs. All it would require under the present design is installing a default pref-file for the Adblock branch.
.
Btw, where do you think there's duplicate-code?
Back to top
View user's profile Send private message
kmike



Joined: 27 May 2004
Posts: 6

PostPosted: Sat May 29, 2004    Post subject: Re: Patched Adblock Reply with quote

wonkothesane wrote:

Combine that with the fact that I don't view this as a particularly critical bug, and I probably won't fix this anytime soon unless a) a few people ask for it and b) somebody gives me a UA string for a browser that this feature works in when using the official adblock xpi.

Don't know if it's still important, but selection of an item in "All blockable items" list appears to work in linux trunk nightly from 2004-04-07-09, with old adblock v35. Build from 2004-04-18-10 doesn't work.. something has changed between these two.
Back to top
View user's profile Send private message
Guest






PostPosted: Sat May 29, 2004    Post subject: Re: Patched Adblock Reply with quote

kmike wrote:
wonkothesane wrote:

Combine that with the fact that I don't view this as a particularly critical bug, and I probably won't fix this anytime soon unless a) a few people ask for it and b) somebody gives me a UA string for a browser that this feature works in when using the official adblock xpi.

Don't know if it's still important, but selection of an item in "All blockable items" list appears to work in linux trunk nightly from 2004-04-07-09, with old adblock v35. Build from 2004-04-18-10 doesn't work.. something has changed between these two.


Ah, yes, I found the problem: another API change, this time in the tree widget code. The selection object was removed, which is about what I expected. Poking through the new API to see how we get selections now.

Patch was checked in on 2004-04-16 by varga +AT+ nixcorp.net for bug 221619

:: the bug and the new nsITreeBoxObject.idl

I'll try to get a fix for this by the end of the day. Gotta love weekends.
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Sat May 29, 2004    Post subject: Reply with quote

Oops, that last post was by me. rue, do you think you could edit out the long URLs?

And I found the fix.


in filterall.js->init()
Code:

if(tree.treeBoxObject.selection) {
      tree.treeBoxObject.selection.select(0);
   } else {
      tree.treeBoxObject.view.selection.select(0);
}


and

in filterall.js->onSelectionChange()
Code:

var selection = tree.treeBoxObject.selection;
if(!selection) selection = tree.treeBoxObject.view.selection;


Yay for reading bugs; the view.selection was straight out of one of the comments Smile

Updated patched version coming soon, then I SWEAR I'll try to get n37 working!
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
iwpg
Guest





PostPosted: Sat May 29, 2004    Post subject: Reply with quote

rue wrote:
Per n37, I may have found a better solution than eval'ing different strings for the origContentPolicy calls. It seems the following syntax is permitted:
Code:
// apiConstants is an object, but .notReal is NOT defined for it.
// this allows us to pass "undefined", maintaining two
// totally different calls in one line
origContentPolicy.shouldLoad(
            contentType, contentLocation,
            requestOrigin, requestingNode,
            apiConstants.oldStyleAPI?apiConstants.notReal:mimeTypeGuess,
            apiConstants.oldStyleAPI?apiConstants.notReal:extra
      );


Are you doing this from inside your own shouldLoad function, with exactly the same arguments that you received? If so, wouldn't it be easier to use
Code:
origContentPolicy.shouldLoad.apply(origContentPolicy, arguments)
?
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Sun May 30, 2004    Post subject: Reply with quote

wonko:
n37 is basically ready to go.
.
Unfortunately, I'm not seeing any way to use the "extra" parameter with the May 28th nightly. Even passing a generic nsISupports doesn't work. n36 actually introduced a use for this, so I guess we'll be hijacking the mimeTypeGuess. If you have a moment, try verifying this with another nightly / firefox.
.
Btw, nice call on the tree-selection change.


iwpg:
It's partly the tradeoff between readability and overhead, and partly just trying new stuff. For the particular case of origContentPolicy(), you're right- it's easier to pass everything as we got it. But, I was also applying it to the policy-call in "addfilterdialog.js" and "filterall.js" -- there, it's actually pretty useful.
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Sun May 30, 2004    Post subject: Reply with quote

The wait is over:
n37 pass 3 . (right-click:save): Installer, and jar-file.
[ Obj-Tabs are presently disabled. ]
The obj-tab issue actually isn't related to n36.
.
I was just installing Java (for object-enablement) when windows went crazy on the virtual hard-drive. Rather than wait for windows' reinstall, I'll just offer what's done.
.
All that's left is adding EM-packaging and... we'll be at parity with ourselves. Seriously, whitelists are coming. :P


Last edited by rue on Sun May 30, 2004; edited 1 time in total
Back to top
View user's profile Send private message
Sven
Guest





PostPosted: Sun May 30, 2004    Post subject: Reply with quote

rue wrote:
The wait is over:
n37 pass 3 . (right-click:save): Installer, and jar-file.
[ Obj-Tabs are presently disabled. ]
The obj-tab issue actually isn't related to n36.

Great! This works in a recent Mozilla nightly!
Also thanks to Wonko for helping out with the patched 0.5 Smile
Back to top
Guest






PostPosted: Sun May 30, 2004    Post subject: Reply with quote

Thanks rue! Good to see you back. New version seems to be working ok so far, but for some reason the AdBlock statusbar button is now on the far righthand side of the statusbar. Is this by design or a bug of some kind? Anyone else seen this? Ever thought of making the AdBlock button a standard button in the customize dialog, so users can place it whereever they want in Fx? I'd love to see "AdBlock" get replaced with a small icon too, making the button smaller, but I think that's been suggested before and I suspect you have more important things to work on than aesthetics right now Smile.

I saw a few AdBlock JS Console errors when I initially installed it as well, followed by a crash. I'm not sure if the crash was adblock related, and I haven't seen any other JS Console errors since then (or crashes). Maybe it was a just a one-time or post-install thing. Not sure, I'll let you know if I see them again.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040526 Firefox/0.8.0+
Back to top
Paradox52525



Joined: 25 Apr 2004
Posts: 1

PostPosted: Sun May 30, 2004    Post subject: Reply with quote

Dangit I keep getting logged out of this forum whenever I post. That guest was me BTW though...
Back to top
View user's profile Send private message
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Sun May 30, 2004    Post subject: Reply with quote

rue wrote:
The wait is over:
n37 pass 3 . (right-click:save): Installer, and jar-file.
[ Obj-Tabs are presently disabled. ]
The obj-tab issue actually isn't related to n36.
.
I was just installing Java (for object-enablement) when windows went crazy on the virtual hard-drive. Rather than wait for windows' reinstall, I'll just offer what's done.
.
All that's left is adding EM-packaging and... we'll be at parity with ourselves. Seriously, whitelists are coming. :P


Actually, speaking of EM-packaging, that's what I spent most of yesterday futzing with (on my own code, to prepare for applying same changes to n37). I think the issues I've been having so far are mostly related to buggy code in the EM, and one bug due to adblock's architecture.

The main issues I've seen so far are:
1) Importing chrome://adblock/skin/*.css files from XUL files has issues the first time the XUL window is opened, causes general "light" breakage.
2) Because all extensions installed from install.rdf files are done to profile, we can't put nsAdblock.js the components directory, even though that's where it should go. Really weird behavior on this one, listen: calling loadSubScript on the component.js file would cause the subsystem to throw an exception saying "couldn't open channel, possibly due to bad scheme?". Now get this: if you put that call in a try/catch block, and put malformed code in the catch block, and exception would be thrown again, but the code would load and run just fine! Really weird. And yes, I realize that install.js doesn't touch nsAdblock.js if it's a profile install.
3) Trying to install a locale doesn't work, causes the "Finishing Extension Installation" dialog.

Luckily, we can avoid all three of those bugs by simply ignoring the "official" extension layout and putting files where they shouldn't be (e.g. css files in the content directory, commenting out the locale declaration, and not putting nsAdblock.js in the components directory.

I'll play around with n37 a bit. Nice work as always rue, sorry I couldn't be f more help with getting this out the door sooner. Maybe I can be of help in getting n37 repackaged for 0.9 before the milestone release :)
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Sun May 30, 2004    Post subject: Reply with quote

rue wrote:
The wait is over:
n37 pass 3 . (right-click:save): Installer, and jar-file.
[ Obj-Tabs are presently disabled. ]
The obj-tab issue actually isn't related to n36.
.
I was just installing Java (for object-enablement) when windows went crazy on the virtual hard-drive. Rather than wait for windows' reinstall, I'll just offer what's done.
.
All that's left is adding EM-packaging and... we'll be at parity with ourselves. Seriously, whitelists are coming. :P


OK, I've been testing out n37, and it has one of the exact same problems I ran into when I was working with n35.

Go to www.eschew.org/filters.txt and install those filters into Mozilla (I'm using Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8a2) Gecko/20040521). Enable Remove Ads and Collapse Blocked Elements. Then go to versiontracker.com. The entire page will be blank (white). This is due to the innerHTML being set to the null string when the nodename matches "iframe." (line 450 component.js). Now try going to slashdot.org (might need to reload a time or two). This should consistently produce a crash.

So, add explicit braces to the if-loop and comment out the line. Now the crash and whiteness are gone, but the elements are not collapsed.

I tried copying the old adblockRemoveSlow() method wholesale, adding the immediate argument, from my patched copy, and that fixed the problem.

I'll see about repackaging this for the EM.
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
DzM
Guest





PostPosted: Sun May 30, 2004    Post subject: More wonky behavior from n37 Reply with quote

I'm trying to hit:

http://www.wunderground.com/

The page just doesn't open. Grey screen. Nothing more.

I've reduced the filter set to:

ads

In theory for this page this will match the images that come from the server "ads.wunderground.com". Unfortunately even this extremely simple rule makes the page not display at all. If I change the filter to:

foobar

the page now displays correctly (though obviously all the ads are now intact).
Back to top
Guest






PostPosted: Mon May 31, 2004    Post subject: Reply with quote

n37 doesn't work at all for me. Firefox trunk starts up fine, and everything's peachy. It's just that there's a conspicuous Adblock button at the bottom right corner instead of the bottom left, and that the filters apparently don't do anything anymore. They say an image is blocked, but I still see it. For reference, I'm on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040530 Firefox/0.8.0+ (johnleemk) with a fresh profile. I have TBP, Show Failed URL and SessionSaver 0.2d (latest nightly from a few months back) installed.
Back to top
Guest






PostPosted: Mon May 31, 2004    Post subject: Reply with quote

rue wrote:
The wait is over:
n37 pass 3 . (right-click:save): Installer, and jar-file.
[ Obj-Tabs are presently disabled. ]
The obj-tab issue actually isn't related to n36.
.
I was just installing Java (for object-enablement) when windows went crazy on the virtual hard-drive. Rather than wait for windows' reinstall, I'll just offer what's done.
.
All that's left is adding EM-packaging and... we'll be at parity with ourselves. Seriously, whitelists are coming. :P


Worked it on Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040527 Firefox/0.8.0+.
So cool!
It is impossible however, for it to block *.swf.
it was not listed on List All Blockable Elements, and not worked Overray Flash.
Back to top
Guest
Guest





PostPosted: Mon May 31, 2004    Post subject: Reply with quote

I confirm that there seems to be a problem with flash in nightly 37. Blocking flash works for me, but the blocked elements are not collapsed. Flashblock does not work, too.

Nightly 35 works perfectly for me.

(Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7) Gecko/20040521 Firefox/0.8.0+)
Back to top
Roller
Guest





PostPosted: Mon May 31, 2004    Post subject: Reply with quote

... the Adblock configuration in the lower left corner of the browser window is missing too in nightly 37.

Roller
Back to top
Guest






PostPosted: Mon May 31, 2004    Post subject: Reply with quote

The new about dialog should not be resizeable, and maybe should have a ok button to dismiss it.

You shouldn't hide/kill the preferences window when the about window is opened.

my 2 cents
Back to top
Roller
Guest





PostPosted: Mon May 31, 2004    Post subject: Reply with quote

P.S.: The latest Firefox 0.9 nightly and the latest official Adblock nightly 35 don't cause any problemlos!

ftp://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-0.9/

Roller
Back to top
Guest






PostPosted: Mon May 31, 2004    Post subject: Re: Patched Adblock Reply with quote

wonkothesane wrote:
All right. I've spent the past day or so hacking around with rue's latest n37 release, and have come up with an improved version.

Issues fixed from/improvements over vanilla n37:

    *Repackaged for 0.9 EM, maintaining backwards-compatibility
    * iFrame collapsation no longer broken (no white pages [ versiontracker.com ] , no crashes in mozilla on slashdot.org with the filter /[\/.]ads?[\/.]/)
    * Fixed dragging to allow statusbar element to be dragged to the edges of the statusbar.
    * Added dynamic contextmenu to statusbar element that allows for enabling/disabling adblock straight from the mouse.</li>
    * Added preliminary About and Getting Started dialogs/help pages.</li>
    * Added (functioning) Load Default Filters from Web menuitem.</li>
    * Reworked Adblock-able Items dialog to have an Add button and a Close Dialog button, rather than OK and Cancel. Allows more than one filter addition without reopening the dialog.</li>
    * My server also serves .XPI files as application/x-xpinstall, whereas rue's .Mac account seems to be serving them as application/octetstream ( ok, that one's a stretch Smile )

There are probably some other changes in there, but it's 3 AM and my brain is shutting down. I'll check back here tomorrow afternoon when I wake up. Post any issues you encounter and I'll look into a fix.

There are one or two issues which I'm already aware of (very minor bugs), but I can't really recall them at the moment. Obj-tabs and Overlay Flash are both nonfunctional, unchanged from vanilla n37.


Anyways, here's the new file:
http://www.eschew.org/misc/firefox/adblock.n37-repackaged01.xpi


Perfect!!!!
Worked it!! All of functions!!!
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Mon May 31, 2004    Post subject: Reply with quote

wonko:

You should submit the changes for review, rather than just releasing them.
.
Nothing you've altered is too serious. But the status-context was being reserved, for example -- no need to duplicate the keybinding's functionality. Web install will also be different. The original n37 pass3 (and thus, your patched release) had Not undergone significant testing for the older API. Quite a few things needed subtle alteration, and we've ended up with two completely different builds.
.
Check your pm's on mozillazine. Users prefer simplicity, and not everyone is bleeding-edge: releases should be unified (single source) + completely backwards-compatible.

.
(ps: every time i tried, mozdev refused cvs access. that's why i'm serving off .mac)
Back to top
View user's profile Send private message
mark
Guest





PostPosted: Mon May 31, 2004    Post subject: Reply with quote

This build works for me.
Back to top
wmc
Guest





PostPosted: Mon May 31, 2004    Post subject: Reply with quote

I'm glad to see that work is continuing on one of Firefox's best extensions. Does anyone know if there are any immediate plans to add a whitelist feature to adblock. This feature is sorely missed.
Back to top
Ray Adams
Guest





PostPosted: Mon May 31, 2004    Post subject: Reply with quote

Yes its work now for all version of Mozilla ia have, even with last night builds. But where is AdBlock button for Flash animation? Sad
Back to top
mark
Guest





PostPosted: Mon May 31, 2004    Post subject: Reply with quote

Ray Adams wrote:
Yes its work now for all version of Mozilla ia have, even with last night builds. But where is AdBlock button for Flash animation? Sad
"Obj-tabs and Overlay Flash are both nonfunctional, unchanged from vanilla n37." as the top post says.
Back to top
Ray Adams
Guest





PostPosted: Tue Jun 01, 2004    Post subject: Reply with quote

I was wrong! 37 doesn't work good. A lot of sites stops to loading when i filter some contents. www.warp2search and much more! And i don't use regular expresions! Just somethink like this http://ads.firingsquad.com* and so on Sad.
I realy need to use last Mozilla releases but without AdBlock it useless for me Sad and niw i stick with old version of Mozilla+(Old)AdBlock. Guys, please! Release fully functional version Sad
Back to top
bry
Guest





PostPosted: Tue Jun 01, 2004    Post subject: Reply with quote

wonkothesane and rue thanks a ton for your effort on this new version, but as others are saying, it just isn't working.

I agree very strongly with rue about cooperating on a single release track instead of two seperate and possibly incompatible versions.

For other users: the Adblock 0.5 d2 nightly 35 (shown here) works very well with the Aviary branch (even though it isn't 0.9 compatible it functions just fine with recent Aviary nightlies) so I suggest sticking with that until a less-buggy and less feature-breaking release of Adblock comes along.

Good luck rue and wonk
Back to top
wonkothesane
The Other Developer


Joined: 22 May 2004
Posts: 210

PostPosted: Tue Jun 01, 2004    Post subject: Reply with quote

To bry and Ray Adams: are you using rue's n37 or my patched n37? Also, please provide your browser UA string and the sites you're visiting that aren't working, etc.

And yes, rue and I are going to be collaborating on future releases Wink
Back to top
View user's profile Send private message Send e-mail Visit poster's website AIM Address
bry
Guest





PostPosted: Wed Jun 02, 2004    Post subject: Reply with quote

Hi wonk,

yes I was using your n37, the one you added in the first post (http://www.eschew.org/misc/firefox/adblock.n37-repackaged01.xpi)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040601 Firefox/0.8.0+

Here is a site that your n37 breaks pretty obviously. Using the filters in the sticky 'Advanced Filters' thread.

www.livejournal.com

Good luck!
Back to top
dzm
Guest





PostPosted: Wed Jun 02, 2004    Post subject: Reply with quote

bry wrote:
Here is a site that your n37 breaks pretty obviously. Using the filters in the sticky 'Advanced Filters' thread.

www.livejournal.com
You can't blame n37 for the Advanced Filters breaking LiveJounral. Much of the graphics for LiveJournal comes from a machine called stat.livejournal.com. The Advanced Filter contains:

/[\W_](b(an|nr)s?|jump|redir(ect|s)?|stat)[\W_]/

This catches any URL that has the word "stat" in it.

Change this filter to:

/[\W_](b(an|nr)s?|jump|redir(ect|s)?)[\W_]/

and LJ will work again. You can also negate LJ in the RegEx pattern:

/[\W_](b(an|nr)s?|jump|redir(ect|s)?|stat)(?!\.livejournal)[\W_]/
Back to top
Forlorn
Guest





PostPosted: Wed Jun 02, 2004    Post subject: Reply with quote

Well, i must say adblock is not installing on my 2 pcs at the office with the lastest build from firefox. The xpi is a selfinstaller, or what?

Adblock is so important to me that I don't update to firefox 0.9 on my home pcs cause it's not running.

Crying or Very sad
Back to top
Guest






PostPosted: Thu Jun 03, 2004    Post subject: Reply with quote

Starting with a Mozilla nightly about a day ago the AdBlock button has begun being greyed out with the text "Unloaded". Additionally the Mozilla contextual menu (right click) has all the AdBlock options on the bottom instead of those relevant to the clicked on resource (so at the bottom of the menu is "AdBlock Image," "AdBlock Embed," "AdBlock Object," "AdBlock Applet," "AdBlock iFrame," and "AdBlock Remove Map").

On the off chance that I messed something up I have removed the install of AdBlock and reinstalled the Wonk posted one from the top of this thread. The behavior persists.

My UA is:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040602
Back to top
TheOneKEA
Guest





PostPosted: Fri Jun 04, 2004    Post subject: Reply with quote

JFYI, workonthesame's patched Adblock works fine on a dirty profile on this build:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8a2) Gecko/20040602 Firefox/0.8.0+ (daihard: XFT+GTK2; opt. for P4/SSE-2)

Any chance of a major version bump when 0.9 is minted and the new EM becomes the status quo?
Back to top
milkbox
Guest





PostPosted: Sun Jun 06, 2004    Post subject: Reply with quote

I'm currently using the 0.5d2 nightly37 pass3 version of Adblock from Sboulema's Extensions Mirror and it breaks http://www.soccerage.com. The page shows up and as soon as it finishes loading, disappears and just keeps on reloading indefinitely with nothing showing up on the screen. As soon as I disable Adblock, things are fine. Other than that, everything seems okay.

I'm running Stipe's 06 June build on Win98. I also tested it on Stipe's 05 June build and Moox's 03 June builds with the same results.
Back to top
hank



Joined: 15 Nov 2003
Posts: 58

PostPosted: Sun Jun 06, 2004    Post subject: Good report here Reply with quote

Using

http://www.eschew.org/misc/firefox/adblock.n37-repackaged01.xpi

*I don't know if that's the current one or not!?! it's all I knew about*

I have no problems using:

Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8a2) Gecko/20040604 Firefox/0.8.0+ (MMx)

Mac OSX 10.3.4, Powerbook G3 "Pismo" 900mhz PowerLogix, 1024mb RAM.
Back to top
View user's profile Send private message
milkbox
Guest





PostPosted: Mon Jun 07, 2004    Post subject: Re: Good report here Reply with quote

hank wrote:
Using

http://www.eschew.org/misc/firefox/adblock.n37-repackaged01.xpi

*I don't know if that's the current one or not!?! it's all I knew about*



That's probably the newest. I downloaded it and everything's fine and dandy. Thanks!
Back to top
Guest






PostPosted: Tue Jun 08, 2004    Post subject: Re: Patched Adblock Reply with quote

vanilla n37 was not worked on Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+.

I think that cause is Extension-package-method has changed. Do you have any update schedule? I'm sorry if this has already posted.
Back to top
Guest






PostPosted: Wed Jun 09, 2004    Post subject: Re: Patched Adblock Reply with quote

Anonymous wrote:
vanilla n37 was not worked on Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+.

I think that cause is Extension-package-method has changed. Do you have any update schedule? I'm sorry if this has already posted.


Oh, it worked on 0.9rc1. Yeah! Smile
Back to top
Guest






PostPosted: Wed Jun 09, 2004    Post subject: Re: Patched Adblock Reply with quote

Anonymous wrote:
Anonymous wrote:
vanilla n37 was not worked on Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+.

I think that cause is Extension-package-method has changed. Do you have any update schedule? I'm sorry if this has already posted.


Oh, it worked on 0.9rc1. Yeah! Smile


Really? Blocking iframes work, too?
Back to top
Guest






PostPosted: Wed Jun 09, 2004    Post subject: Re: Patched Adblock Reply with quote

Anonymous wrote:

Really? Blocking iframes work, too?

blocking iframes don't work
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7) Gecko/20040608 Firefox/0.8.0+
--
electrocat
Back to top
Guest






PostPosted: Thu Jun 10, 2004    Post subject: Re: Patched Adblock Reply with quote

Anonymous wrote:
Really? Blocking iframes work, too?


No. Sad
Back to top
Sander
Guest





PostPosted: Thu Jun 10, 2004    Post subject: Reply with quote

Flashblock does not work either in 0.9RC1 with the patched .37.
Back to top
Guest






PostPosted: Sat Jun 12, 2004    Post subject: Reply with quote

Quote:
Flashblock does not work either in 0.9RC1 with the patched .37.


I can duplicate that on a clean install with a new profile.
Back to top
Guest






PostPosted: Sun May 15, 2005    Post subject: Reply with quote

[quote="rue"]Everyone:
Just a quick heads-up:
.
The "patched" build is not the future of Adblock. It's a good tide-over until n37; but the reason it's failing is the cumbersome nature of its design -- essentially maintaining two copies of code for the differing APIs.
.
n37 addresses the APIs in a unified manner, minimizing overhead. Where n37 [i]fails[/i] is the same place the unreleased n36 did. Amusingly, it's been held-up due to lack of a proper test-box -- an issue that should shortly be resolved. Btw, moz1.3.1 under macOs 9 runs n37 fine. You can scope the latest source here: <blockquote>[color=darkred]n37 test.ii[/color] . ([i]right-click:save[/i]): <a href="http://homepage.mac.com/rue/Adblock/test-viii/adblock-0.5-dev.xpi">Installer</a>, and <a href="http://homepage.mac.com/rue/Adblock/test-viii/adblock.jar">jar-file</a>.
[ This is not linked for install. Only download if you're interested in the source. ]</blockquote> Travels, graduations, and other events did beckon away for a time. But I'm on top of all pertinent threads, and development has resumed. Keep it here.[/quote]
Back to top
Guest






PostPosted: Thu Oct 27, 2005    Post subject: Reply with quote

kmike wrote:
Quote:

The problem is that I tried testing the "official" adblock xpi on some older Firefox/Mozilla builds, and this feature didn't work in the two builds I tried (both from the first week of May.) Combine that with the fact that I don't view this as a particularly critical bug, and I probably won't fix this anytime soon unless a) a few people ask for it and b) somebody gives me a UA string for a browser that this feature works in when using the official adblock xpi.

Ok, here's the build with working feature in question:
Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7b) Gecko/20040321
The problem is that its kind of old... no nightlies of that period at ftp.mozilla.org, sorry Sad
I'll try to download some random nightlies and see if it works.

UPDATE:
Tried 2004041810 trunk nightly build, the same error as in the current trunk: "selection has no properties". I'll try the earliest trunk build available from ftp.mozilla.org (2004-04-07-09)
Back to top
Display posts from previous:   
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group