The Adblock Project Forum Index The Adblock Project
Pull up a seat ...stay a while.
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

Adding adframe blocking support

 
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main
View previous topic :: View next topic  
Author Message
Guest






PostPosted: Fri Oct 24, 2003    Post subject: Adding adframe blocking support Reply with quote

Hi !
Thanks for the great extension to block all kind of annoying ads first !

Then I would like to ask if it is possible to add adframe blocking support ?

Sometimes (with lycos eg http://membres.lycos.fr/sfam/forum/ and click any link) a frame dispalying google ads is shown on the right of the screen. Adblock can of course block the ads in it, also i think it can block the frame from being loaded, but still the <frameset width=xxx > is present, so that the space for the adframe is preserved...

Is there any way to implement a rewriting of the <frameset> tag if one or more frame from this frameset are removed, so the wasted space is converted in useful space ?

It would be very interesting !
Thanks a lot
Raf
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Sat Oct 25, 2003    Post subject: Reply with quote

As you noted, Adblock does block frames. Adding this entry removed the ad-frame (Width included) from your example:
.
Code:
http://ads.multimania.lycos.fr/ad/google/frame.php*
.
Since frames are pretty much a base-tag, it doesn't strike me as useful to put an option in the context-menu. But the "Adblock-able Items" list shows them -- just click the statusbar-element.

More importantly, the frame in your example was created by a script. I'm not sure where you determined a 'framewidth' attribute as responsible, but if the above filter doesn't work for you, try blocking the page scripts. You'll also find them listed in "Adblock-able Items".
Back to top
View user's profile Send private message
Guest






PostPosted: Mon Oct 27, 2003    Post subject: Reply with quote

Thanks for your answer rue, but it didn't solve the problem, maybe you thought this due to a weird handling of the php code and the adframe (lycos let the first php page without adframe, then after a link is clicked shows the bar, also sometimes, when you simply click refresh, the adframe disappear, more or less randomly) BUT ! i made you a test page in pure html :

http://membres.lycos.fr/rslinckx/adframe.htm

There you can test that blocking even the *ads* keyword, let a blank space at the right of the screen, in place of the adframe, i can figure out why !
The source code is pretty weird and i don't knwo that much about html and javascript..

Could you check it out ?
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Tue Oct 28, 2003    Post subject: Reply with quote

Done.
.
The frameset "cols" property is now set per blocked frames and tracked for future modifications by scripts.
.
Just grab the updated XPI from the Dev-Builds page.
Back to top
View user's profile Send private message
Guest






PostPosted: Tue Oct 28, 2003    Post subject: Reply with quote

DAAAmn
You did it !!
How can I thank you for that !! Cool

Keep up the good work !
Back to top
kikidonk
Guest





PostPosted: Thu Nov 20, 2003    Post subject: Reply with quote

Rue Smile
I just installed the latest nightly build, 0.5 d2 build18

The problem you solved some weeks ago reapeared ...
Just check out the link I gave you last time..
Is this normal ?

Thanks !
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Thu Nov 20, 2003    Post subject: Reply with quote

kikidonk:
Adblock's FastCollapse feature was landed shortly after, and isn't compatible with the frameset-collapsation. FastCollapse bypasses the window-timeout that completely hides blocked elements, which means they still take up screen-space.
.
Disable FastCollapse, and the previous behaviour will return.
Back to top
View user's profile Send private message
kikidonk
Guest





PostPosted: Thu Nov 20, 2003    Post subject: Reply with quote

Yes you're once again right ! Smile

But i just don't understand what is the fast collapse and what it does better than before ?

Thanks
kikidonk
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Thu Nov 20, 2003    Post subject: Reply with quote

Here's the thread that led to it.
Back to top
View user's profile Send private message
kikidonk
Guest





PostPosted: Fri Nov 21, 2003    Post subject: Reply with quote

Ok !
So it's just a sort of display time optimisation, but that don't work with all the options (such as frame ..)

Thanks !
Back to top
Marvin



Joined: 05 Feb 2007
Posts: 31

PostPosted: Mon Feb 05, 2007    Post subject: Reply with quote

wow stuff Smile Smile
http://nakedcamerondiaz.info/blog/comments/64752
regards, Marvin
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group