The Adblock Project Forum Index The Adblock Project
Pull up a seat ...stay a while.
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

ad filter in latest nightly

 
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main
View previous topic :: View next topic  
Author Message
Inglo



Joined: 01 Dec 2003
Posts: 2

PostPosted: Sat Dec 06, 2003    Post subject: ad filter in latest nightly Reply with quote

In the latest nightly there seems to be an unremovable filter that's just "ad", it ends up removing tons of stuff that shouldn't be removed. Anything named "header" or "thread" for example. Is this supposed to be there or is it a mistake of mine?
Back to top
View user's profile Send private message
Org



Joined: 23 Oct 2003
Posts: 349

PostPosted: Sat Dec 06, 2003    Post subject: Reply with quote

Something happened to my filters when I installed nightly 28 (not quite sure what the previous version was. maybe 24). For some reason the filter

*/ad/*

seems to work just as

ad

which is obviously far too greedy. (I can see this when check the blocked and blockable elements.) It blocks tons of unwanted stuff as well as tons of wanted stuff. Nightly 28 seems to handle such a filter definition wrong.

I worked around it by changing my filter to this:

/\/ad[zs]?\//
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Sat Dec 06, 2003    Post subject: Reply with quote

nightly 29 is posted.
.
For the regexp-junkies out there, here's what changed:
Code:
Orig: pattern.replace(/(?:^\*).|.(?:\*$)/g, "")
New:  pattern.replace(/(?:^[\*]*)(.(?:[^\*]|[\*]+[^\*])*)(?:[\*]*$)/g, "$1")
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group