The Adblock Project Forum Index The Adblock Project
Pull up a seat ...stay a while.
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

"Collapse Blocked Elements" appears broken in nigh

 
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main
View previous topic :: View next topic  
Author Message
iwpg
Guest





PostPosted: Fri Dec 05, 2003    Post subject: "Collapse Blocked Elements" appears broken in nigh Reply with quote

In nightly build 27, the "Collapse Blocked Elements" seems to be broken. When it is enabled, Adblock doesn't block anything until "Collapse..." is disabled _and_ Mozilla is restarted. This happens with both "Hide ads" and "Remove ads", if that helps. It was generating error messages in the JavaScript console, but now it doesn't seem to be doing that any more for some reason.
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Fri Dec 05, 2003    Post subject: Reply with quote

iwpg:
Duplicate-removal (n27) required special handling to keep the filter-list from reloading twice. Collapsation was killed in the mix. Fixed.
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Fri Dec 05, 2003    Post subject: Reply with quote

>append:
Whoa- not fixed yet. Dont' update yet.
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Sat Dec 06, 2003    Post subject: Reply with quote

nightly 28 pass-3 is posted.
.
The actual bug was this: any pref-change besides the filters erased adblock's in-memory filter pool. It now uses custom observer-service notifications for filter-changes and pref-file saving. Bool-prefs get the pref-observer treatment, as before.
.
Fixed (yay!)
Back to top
View user's profile Send private message
Display posts from previous:   
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group