The Adblock Project Forum Index The Adblock Project
Pull up a seat ...stay a while.
 
 FAQFAQ   SearchSearch   MemberlistMemberlist   UsergroupsUsergroups   RegisterRegister 
 ProfileProfile   Log in to check your private messagesLog in to check your private messages   Log inLog in 

adblock crashes firebird on certain filters

 
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main
View previous topic :: View next topic  
Author Message
ric
Guest





PostPosted: Tue Nov 25, 2003    Post subject: adblock crashes firebird on certain filters Reply with quote

Hi folks

adblock v0.5 d2 nightly 20
firebird 0.7
RedHat Linux 9.0

If I add the filter 'http://ads.osdn.com/*' and visit freshmeat.net, firebird crashes.
If I remove the filter everything is OK. The same applies with several other filter/site
combinations.

I can't reproduce the exact example above on mozilla, but I have seen some crashes
there too when using adblock.

Cheers
Ric
Back to top
ric
Guest





PostPosted: Wed Nov 26, 2003    Post subject: adblock crashes firebird on certain filters Reply with quote

Here's another one:

Filter 'http://ads.guardian.co.uk/*' and go to http://www.guardian.co.uk/

Crashes firebird, but not mozillla 1.5.

Can anyone recreate this?
Thanks
Ric
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Wed Nov 26, 2003    Post subject: Reply with quote

ric:
No need to confirm, I already have an idea what's causing it.
.
I'll post a test-case for you either later today, or early tomorrow.
Back to top
View user's profile Send private message
ric
Guest





PostPosted: Thu Nov 27, 2003    Post subject: Reply with quote

Great, thanks. I won't be able to test it until after the weekend, so no rush Smile

Cheers
Ric
Back to top
Sylvain
Guest





PostPosted: Thu Nov 27, 2003    Post subject: Mozilla 1.4 crashes too Reply with quote

Hello,

Ric's example makes my Mozilla 1.4 crash too. The only way not to crash for me is to use the "hide mode" instead of the the "remove mode" (the "fast collapse mode" does not change anything).

Numerous sites cause similar crashes. Like http://www.rueducommerce.com with the upper right ad banner.

Bests,

Sylvain
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Sun Nov 30, 2003    Post subject: Reply with quote

I haven't forgotten this thread -- for the non-Americans out there, this was a major holiday-weekend.
.
Testing has been postponed until Monday.
Back to top
View user's profile Send private message
Juhaz
Guest





PostPosted: Mon Dec 01, 2003    Post subject: Reply with quote

Seems to crash Mozilla 1.5 (Linux) as well, not on page view, but if I try to list all blockable elements - BANG.
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Mon Dec 01, 2003    Post subject: Reply with quote

Everyone:
Are these custom builds you're running on Linux?
.
Does opening "List Adblock-able.." crash when Adblock is disabled, too?


Juhaz:
This is just for pages with iframes, right?
Back to top
View user's profile Send private message
Sylvain
Guest





PostPosted: Mon Dec 01, 2003    Post subject: Nightly 23 crashes with Mozilla 1.4 under Linux Reply with quote

Hello,

With Mozilla 1.4 under Linux and AdBlock nightly 23 (just downloaded), Mozilla crashes on http://www.rueducommerce.com as described before. This configuration seems not to crash with adblockable list (but Mozilla 1.4 has never crashed like that before for me).

Moreover, it seems that any change between "Hide" and "Remove" option is not taken into account unless another menu option is manipulated (it enables the "Revert" button whereas just toggling between "Hide" and "Remove" does not enable it).

Sylvain
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Mon Dec 01, 2003    Post subject: Reply with quote

d2 nightly 24 is posted.
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Mon Dec 01, 2003    Post subject: Reply with quote

Sylvain:
You're right- due to the pref-rearrangement, the radio-buttons weren't activating the proper flags. That's fixed.
.
Also, I've landed a candidate-patch for the iframe bug. Let me know if it works.
Back to top
View user's profile Send private message
ric
Guest





PostPosted: Mon Dec 01, 2003    Post subject: Reply with quote

Hi rue

For reference, these are not custom builds. Firebird is an RPM from fedora:
MozillaFirebird-0.7-0.fdr.2.rh90

I've just tried nightly 24. It no longer crashes on the guardian.co.uk or freshmeat.net
examples, which is great, thanks. However, instead of blank space where the ads used
to be, there are now some weird buffered image effects, which flash and change as window
focus changes. Please see an example at: http://cns.georgetown.edu/~ric/adblock.png
... look at the removed ads down the right-hand side of the page.

Cheers
Ric
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Mon Dec 01, 2003    Post subject: Reply with quote

nightly 24 pass-2 is posted.
.
This should fix the redraw-issue.
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Tue Dec 02, 2003    Post subject: Reply with quote

nightly 24 pass-4 is posted.
.
The earlier patches (which blocked collapsation) were backed-out, and a new method for uncollapsed iframes has landed: writing empty html to the element.
.
Also, the pref-list restores the scrollView completely, now.
Back to top
View user's profile Send private message
Wolfey



Joined: 23 Oct 2003
Posts: 45
Location: Kittanning, PA

PostPosted: Tue Dec 02, 2003    Post subject: Reply with quote

(Thanks for pointing me to the right thread, rue Razz)

Just tried out Pass 4, and when "Collapse Blocked Elements" is checked, it works Smile

However, on some sites, when "Collapse Blocked Elements" is unchecked, a black area will appear in place of the blocked element, and the throbber and status bar act as if the site is still loading. If I click on the "Stop" button, the page will stop loading, and the black area will disappear.
Back to top
View user's profile Send private message Visit poster's website
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Tue Dec 02, 2003    Post subject: Reply with quote

Wolfey:
Yea- the iframe-handling needs further work. By writing to the element directly, the empty html is created, but then the page keeps waiting for something...
.
Maybe firing an "onload" event will trip the appropriate listeners.
Back to top
View user's profile Send private message
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Tue Dec 02, 2003    Post subject: Reply with quote

nightly 24 pass-5 is posted.
.
I didn't think this would work, but it did: calling window.stop() within the iframe's subdocument context.
Back to top
View user's profile Send private message
Wolfey



Joined: 23 Oct 2003
Posts: 45
Location: Kittanning, PA

PostPosted: Tue Dec 02, 2003    Post subject: Reply with quote

Just tried out Pass 5, and the "black area that downloads something" glitch that shows up when "Collapse Blocked Elements" is unchecked no longer occurs Smile
Back to top
View user's profile Send private message Visit poster's website
Sylvain
Guest





PostPosted: Tue Dec 02, 2003    Post subject: "Remove" works but "Collapse" still cras Reply with quote

Hello,

With Mozilla 1.4 under Linux with nightly 24, the "Remove" option works fine Smile

But if the "Collapse" menu option is enabled, it still crashes on the same web sites: http://www.rueducommerce.com and http://www.guardian.co.uk/

However, I am happy with the "remove" option. Thanks a lot,

Sylvain
Back to top
ric
Guest





PostPosted: Tue Dec 02, 2003    Post subject: Reply with quote

Hi rue

I have just downloaded the latest nightly 24 and can confirm what Sylvain is seeing.
Everything works fine (no ads, no glitches), unless "Collapse Blocked Elements" is enabled,
in which case Firebird crashes.

That's fine by me (I don't need collapsing) but I guess it still needs fixing Smile

Cheers
Ric
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Tue Dec 02, 2003    Post subject: Reply with quote

nightly 25 pass-2 is posted.
.
More patches for iframes. If the crashing still occurrs, there's one last approach I can try.
Back to top
View user's profile Send private message
Sylvain
Guest





PostPosted: Wed Dec 03, 2003    Post subject: Nightly 25 still crashes with "collapse" enabled Reply with quote

Hi,

Unfortunately, Mozilla 1.4 under Linux still crashes with AdBlock v0.5 nightly 25 on the same web sites when "collapse" is enabled. But as ric said, "collapse" is not a major feature so it is fine to me. Smile

Sylvain
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Wed Dec 03, 2003    Post subject: Reply with quote

Would one of you mind trying a problem-site with "Hide" selected, instead?
.
"Hide" applies visibility:hidden, instead of the collapsation's display:none.
Back to top
View user's profile Send private message
Guest






PostPosted: Wed Dec 03, 2003    Post subject: Reply with quote

Yes, only crashes with remove + collapse, hide seems safe.
Back to top
rue
Developer


Joined: 22 Oct 2003
Posts: 752

PostPosted: Thu Dec 04, 2003    Post subject: Reply with quote

nightly 26 is posted.
.
Fingers crossed... collapsation-crash fixed?
Back to top
View user's profile Send private message
Juhaz
Guest





PostPosted: Thu Dec 04, 2003    Post subject: Reply with quote

Yes, it's fixed. Works fine.

Thank you.
Back to top
Display posts from previous:   
Post new topic   Reply to topic    The Adblock Project Forum Index -> Main All times are GMT + 1 Hour
Page 1 of 1

 
Jump to:  
You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot vote in polls in this forum


Powered by phpBB © 2001, 2005 phpBB Group