The Adblock Project

Guest · Posted: Fri Oct 24, 2003 Post subject: Adding adframe blocking support

Hi !
Thanks for the great extension to block all kind of annoying ads first !

Then I would like to ask if it is possible to add adframe blocking support ?

Sometimes (with lycos eg http://membres.lycos.fr/sfam/forum/ and click any link) a frame dispalying google ads is shown on the right of the screen. Adblock can of course block the ads in it, also i think it can block the frame from being loaded, but still the <frameset width=xxx > is present, so that the space for the adframe is preserved...

Is there any way to implement a rewriting of the <frameset> tag if one or more frame from this frameset are removed, so the wasted space is converted in useful space ?

It would be very interesting !
Thanks a lot
Raf

rue · Developer Joined: 22 Oct 2003 Posts: 752

As you noted, Adblock does block frames. Adding this entry removed the ad-frame (Width included) from your example:
.

Guest · Posted: Mon Oct 27, 2003 Post subject:

Thanks for your answer rue, but it didn't solve the problem, maybe you thought this due to a weird handling of the php code and the adframe (lycos let the first php page without adframe, then after a link is clicked shows the bar, also sometimes, when you simply click refresh, the adframe disappear, more or less randomly) BUT ! i made you a test page in pure html :

http://membres.lycos.fr/rslinckx/adframe.htm

There you can test that blocking even the *ads* keyword, let a blank space at the right of the screen, in place of the adframe, i can figure out why !
The source code is pretty weird and i don't knwo that much about html and javascript..

Could you check it out ?

rue · Developer Joined: 22 Oct 2003 Posts: 752

Done.
.
The frameset "cols" property is now set per blocked frames and tracked for future modifications by scripts.
.
Just grab the updated XPI from the Dev-Builds page.

Guest · Posted: Tue Oct 28, 2003 Post subject:

DAAAmn
You did it !!
How can I thank you for that !! Cool

Keep up the good work !

kikidonk · Guest

Rue

I just installed the latest nightly build, 0.5 d2 build18

The problem you solved some weeks ago reapeared ...
Just check out the link I gave you last time..
Is this normal ?

Thanks !

rue · Developer Joined: 22 Oct 2003 Posts: 752

kikidonk:
Adblock's FastCollapse feature was landed shortly after, and isn't compatible with the frameset-collapsation. FastCollapse bypasses the window-timeout that completely hides blocked elements, which means they still take up screen-space.
.
Disable FastCollapse, and the previous behaviour will return.

kikidonk · Guest

Yes you're once again right ! Smile

But i just don't understand what is the fast collapse and what it does better than before ?

Thanks
kikidonk

rue · Developer Joined: 22 Oct 2003 Posts: 752

Here's the thread that led to it.

kikidonk · Guest

Ok !
So it's just a sort of display time optimisation, but that don't work with all the options (such as frame ..)

Thanks !

Marvin · Joined: 05 Feb 2007 Posts: 31

wow stuff

http://nakedcamerondiaz.info/blog/comments/64752
regards, Marvin