View previous topic :: View next topic |
Author |
Message |
Guest
|
Posted: Fri Dec 12, 2003 Post subject: |
|
|
rue wrote: | NJH:
/[\W\d]ad(serv(er|e)?|s|v)?[\W\d]/ |
Hello, when i'm using your pattern above, try this http://www.detik.com
it goes blank....
But on your previous build, (i forget which build ) it's okay, Adblock blocks [url]]http://www.detik.com/adv/*[/url] because that regex pattern above...
BTW, i'm using build 31, on Linux Debian Unstable.... only obj-tabs activated
On Adblock-able items, http://ad.detik.com and http://www.detik.com/adv/ it's blocked by Adblock. But the subdocument http://www.detik.com/index.htm (FRAME) didn't show up...
TIA
jef198
jefree |
|
Back to top |
|
 |
Guest
|
Posted: Fri Dec 12, 2003 Post subject: |
|
|
I have not had any problems with the filter, but only because I have not visited any sites where /adv/ is not an advertisment. Clearly you will have to tailor the filter to your own requirements. This is one problem of these big filters. They can give false positives. Try removing the |v from the filter and see if it then lets undesirable ads. |
|
Back to top |
|
 |
rue Developer
Joined: 22 Oct 2003 Posts: 752
|
Posted: Fri Dec 12, 2003 Post subject: |
|
|
No- there's a serious bug with frame-blocking; and I don't think it's Adblock's fault.
.
What it looks like so far: with nested framesets, when a frame is blocked, the browser loses its place and tries to load the same frame with the next frame's url. Adblock says "go ahead and load".. except the frame in question isn't loading -- its sibling is. And thus, the sibling never loads.
.
So far, my patches have only sent it into a weird recursion-loop. But, I'm not done yet... |
|
Back to top |
|
 |
Guest
|
Posted: Wed Dec 31, 2003 Post subject: |
|
|
rue wrote: | No- there's a serious bug with frame-blocking; and I don't think it's Adblock's fault.
.
|
OK. It's mozilla's 1.5.3 fault. I haven't tried mozilla 1.6b yet. But on firebird 0.7 Windows platform, it's okay....
Rue, would you mind to post this bug on bugzilla?
Thanks for this tools... it's cool :
no more ads
TIA
Jefree
jef198 |
|
Back to top |
|
 |
rue Developer
Joined: 22 Oct 2003 Posts: 752
|
Posted: Wed Dec 31, 2003 Post subject: |
|
|
jef:
Hey- I forgot this thread. The issue was fixed back for nightly 32. |
|
Back to top |
|
 |
|